Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added locking information for GNU Hurd #493

Conversation

petterreinholdtsen
Copy link

Patch has been used by Debian package for a while, see https://udd.debian.org/patches.cgi?src=sqlcipher&version=3.4.1-2 .

@sjlombardo
Copy link
Member

Hello @petterreinholdtsen

The policy for the SQLCipher project is to minimize changes that diverge from upstream SQLite whenever possible. This allows us to minimize diffs against the base code and maintain a consistent process for applying core upstream fixes. Thus when issues are reported against SQLCipher that are actually rooted in the upstream SQLite project, i.e. the code originated in SQLite and affects both equally, we generally ask that they be reported to SQLite instead. This usually involves reproducing the issue with standard" SQLite (completely excluding SQLCipher), documenting the issue, and then submitting a summary and/or patch to the SQLite maintainers. If and when appropriate changes are applied to upstream SQLite, the SQLCipher project would then incorporate those fixes as part of our standard release workflow.

This pull request appears to fall into that category. The changes are not specific to SQLCipher or any of the project's extensions, so it would be better to address this with the SQLite project. While we really appreciate you taking the time to submit this pull request, we would not anticipate applying it against SQLCipher at this time. Please let me know if you have any questions.

@sjlombardo sjlombardo closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants