Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-DbcConfig Adding support to multiple names #828 #829

Conversation

MikeyBronowski
Copy link
Contributor

A New PR

THANK YOU - We love to get PR's and really appreciate your time and help to improve this module

Accepting a PR

Before we accept the PR - please confirm that you have run the tests locally to avoid our automated build and release process failing. You can see how to do that in our wiki

https://github.com/sqlcollaborative/dbachecks/wiki

Please confirm you have 0 failing Pester Tests

[x] There are 0 failing Pester tests

Changes this PR brings

Please add below the changes that this PR covers. It doesnt need an essay just the bullet points :-)

Adding support to multiple values in -Name parameter #828
Added test to cover this change

Copy link
Collaborator

@shaneis shaneis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

🚢 it

😉

@SQLDBAWithABeard SQLDBAWithABeard merged commit 253bf18 into dataplat:development Apr 7, 2021
@MikeyBronowski MikeyBronowski deleted the GetDbcConfigMultipleNAme branch April 7, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants