Maintenance Solution retention time check issues

[mikedavem]

Bug Report

General Troubleshooting steps

• [X ] Verified running the latest release of dbachecks?

2.0.9

• [ X] Verified errors are not related to permissions?
• Can duplicate in new/clean PowerShell session (clean = powershell -NoProfile)?

Version Information

• Operating System : Windows Server 2016 / Windows 10
• PowerShell Version: 5.1
• SQL Server (Edition|Version): EE/2017

Steps to Reproduce

When policy.ola.DeleteBackupHistoryCleanUp value is over 2 digits the check is failing.
Let's say I want to keep more 2 years of backup history (~730days) , the check is designed to keep only 2 digits -> 73

• [X ] Attach any screenshots (if possible/allowed)

• Attach output from PowerShell console (if possible/allowed)

Description of Bug

The description of the parameter doesn't suggest any limits for days

but the related check code is limited to 2 digits

$days = [regex]::matches($jobsteps.Command, "dd,-(\d\d)").groups[1].value

We could improve the code as follows to make detection more dynamic:

$days = [regex]::matches($jobsteps.Command, "dd,-(\d*)").groups[1].value

The same applies for

• File Job Cleanup Time
• Delete Backup History Cleanup Time
• Delete Purge History Cleanup Time

[SQLDBAWithABeard]

Closed with 35bb787