Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mssqldef: support cursor in trigger #138

Merged
merged 8 commits into from
Aug 31, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
49 changes: 45 additions & 4 deletions cmd/mssqldef/mssqldef_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,22 +193,63 @@ func TestMssqldefTrigger(t *testing.T) {
assertApplyOutput(t, createTable, nothingModified)

createTrigger := stripHeredoc(`
CREATE TRIGGER [insert_log] ON [dbo].[users] after insert AS insert into logs(log, dt) values ('insert', getdate());
CREATE TRIGGER [insert_log] ON [dbo].[users] after insert AS
insert into logs(log, dt) values ('insert', getdate());
`,
)
assertApplyOutput(t, createTable+createTrigger, applyPrefix+createTrigger)
assertApplyOutput(t, createTable+createTrigger, nothingModified)

createTrigger = stripHeredoc(`
CREATE TRIGGER [insert_log] ON [dbo].[users] after insert
AS
CREATE TRIGGER [insert_log] ON [dbo].[users] after insert AS
delete from logs
insert into logs(log, dt) values ('insert', getdate());
`,
)

assertApplyOutput(t, createTable+createTrigger, applyPrefix+
"CREATE OR ALTER TRIGGER [insert_log] ON [dbo].[users] after insert AS delete from logs insert into logs(log, dt) values ('insert', getdate());\n")
"CREATE OR ALTER TRIGGER [insert_log] ON [dbo].[users] after insert AS\n"+
"delete from logs\n"+
"insert into logs(log, dt) values ('insert', getdate());\n",
)
assertApplyOutput(t, createTable+createTrigger, nothingModified)
}

func TestMssqldefTriggerWithRichSyntax(t *testing.T) {
resetTestDatabase()

createTable := stripHeredoc(`
CREATE TABLE users (
id bigint NOT NULL,
name text
);
CREATE TABLE logs (
id bigint NOT NULL,
log varchar(20),
dt datetime
);
`,
)
assertApplyOutput(t, createTable, applyPrefix+createTable)
assertApplyOutput(t, createTable, nothingModified)

createTrigger := stripHeredoc(`
CREATE TRIGGER [insert_log] ON [dbo].[users] after insert AS
declare
@username varchar(20),
@date datetime
set @date = getdate()
declare
users_cursor scroll cursor for
select name from users order by id asc
open users_cursor
fetch first from users_cursor into @username
close users_cursor
deallocate users_cursor
insert into logs(log, dt) values (@username, @date);
`,
)
assertApplyOutput(t, createTable+createTrigger, applyPrefix+createTrigger)
assertApplyOutput(t, createTable+createTrigger, nothingModified)
}

Expand Down
4 changes: 2 additions & 2 deletions schema/generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -655,9 +655,9 @@ func (g *Generator) generateDDLsForCreateTrigger(triggerName string, desiredTrig
var triggerDefinition string
switch g.mode {
case GeneratorModeMssql:
triggerDefinition += fmt.Sprintf("TRIGGER %s ON %s %s %s AS %s", g.escapeSQLName(desiredTrigger.name), g.escapeTableName(desiredTrigger.tableName), desiredTrigger.time, desiredTrigger.event, strings.Join(desiredTrigger.body, " "))
triggerDefinition += fmt.Sprintf("TRIGGER %s ON %s %s %s AS\n%s", g.escapeSQLName(desiredTrigger.name), g.escapeTableName(desiredTrigger.tableName), desiredTrigger.time, desiredTrigger.event, strings.Join(desiredTrigger.body, "\n"))
case GeneratorModeMysql:
triggerDefinition += fmt.Sprintf("TRIGGER %s %s %s ON %s FOR EACH ROW %s", g.escapeSQLName(desiredTrigger.name), desiredTrigger.time, desiredTrigger.event, g.escapeTableName(desiredTrigger.tableName), strings.Join(desiredTrigger.body, " "))
triggerDefinition += fmt.Sprintf("TRIGGER %s %s %s ON %s FOR EACH ROW %s", g.escapeSQLName(desiredTrigger.name), desiredTrigger.time, desiredTrigger.event, g.escapeTableName(desiredTrigger.tableName), strings.Join(desiredTrigger.body, "\n"))
default:
return ddls, nil
}
Expand Down
130 changes: 130 additions & 0 deletions sqlparser/ast.go
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,8 @@ func (*Insert) iStatement() {}
func (*Update) iStatement() {}
func (*Delete) iStatement() {}
func (*Set) iStatement() {}
func (*Declare) iStatement() {}
func (*Cursor) iStatement() {}
func (*DBDDL) iStatement() {}
func (*DDL) iStatement() {}
func (*Show) iStatement() {}
Expand Down Expand Up @@ -3455,6 +3457,134 @@ func (node ColIdent) walkSubtree(visit Visit) error {
return nil
}

type DeclareType int

const (
declareVariable DeclareType = iota
declareCursor
)

type Declare struct {
Type DeclareType
Variables []*LocalVariable
Cursor *CursorDefinition
}

func (node *Declare) Format(buf *TrackedBuffer) {
var prefix string
buf.Myprintf("declare\n")
switch node.Type {
case declareVariable:
for _, n := range node.Variables {
buf.Myprintf("%s%v", prefix, n)
prefix = ",\n"
}
case declareCursor:
buf.Myprintf("%v", node.Cursor)
}
}

func (node *Declare) walkSubtree(visit Visit) error {
switch node.Type {
case declareVariable:
for _, n := range node.Variables {
if err := Walk(visit, n); err != nil {
return err
}
}
case declareCursor:
if err := Walk(visit, node.Cursor); err != nil {
return err
}
}
return nil
}

type LocalVariable struct {
Name ColIdent
DataType ColumnType
}

func (node *LocalVariable) Format(buf *TrackedBuffer) {
buf.Myprintf("%v %v", node.Name, &node.DataType)
}

func (node *LocalVariable) walkSubtree(visit Visit) error {
if node == nil {
return nil
}
return Walk(
visit,
node.Name,
&node.DataType,
)
}

type CursorDefinition struct {
Name ColIdent
Scroll bool
Select SelectStatement
}

func (node *CursorDefinition) Format(buf *TrackedBuffer) {
var scrollStr string
if node.Scroll {
scrollStr = " scroll"
}
buf.Myprintf("%v%s cursor for\n%v", node.Name, scrollStr, node.Select)
}

func (node *CursorDefinition) walkSubtree(visit Visit) error {
if node == nil {
return nil
}
return Walk(
visit,
node.Name,
node.Select.(*Select),
)
}

const (
OpenStr = "open"
CloseStr = "close"
DeallocateStr = "deallocate"
FetchStr = "fetch"
)

type Cursor struct {
Action string
Fetch string
CursorName ColIdent
Into ColIdent
}

func (node *Cursor) Format(buf *TrackedBuffer) {
if node.Action == FetchStr {
fetch := " "
if node.Fetch != "" {
fetch = fmt.Sprintf(" %s from", node.Fetch)
}
var into string
if !node.Into.IsEmpty() {
into = fmt.Sprintf(" into %s", node.Into.Lowered())
}
buf.Myprintf("%s%s %v%s", node.Action, fetch, node.CursorName, into)
} else {
buf.Myprintf("%s %v", node.Action, node.CursorName)
}
}

func (node *Cursor) walkSubtree(visit Visit) error {
if node == nil {
return nil
}
return Walk(
visit,
node.CursorName,
)
}

// IsEmpty returns true if the name is empty.
func (node ColIdent) IsEmpty() bool {
return node.val == ""
Expand Down