Fixes #469 - query results error out if no custom font is set #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if no custom font has been set from the settings modal, the app crashes. - this fixes the issue by defaulting the custom font to the default font
rathboma
changed the title
|
Not sure what this build failure is about -- seems maybe related to a library upgrade? |
|
Ah, looks like the Travis build is running on node 6 - |
maxcnunes
reviewed
May 7, 2019
| const { customFont } = this.props.config.data.customFont; | ||
| const font = `14px '${customFont}', 'Helvetica Neue', Arial, Helvetica, sans-serif`; | ||
| const customFont = this.props.config.data.customFont || 'Helvetica Neue'; | ||
| const font = `14px '${customFont}' 'Helvetica Neue', Arial, Helvetica, sans-serif`; |
There was a problem hiding this comment.
You removed the , from the customFont. I think the comma is required there.
There was a problem hiding this comment.
yes you are correct. I will fix that.
|
Manually merged in df70052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469