Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1083: Support BigQuery named arguments #1111

Merged

Conversation

barrywhart
Copy link
Member

@barrywhart barrywhart commented May 28, 2021

Resolves #1083

This is a pretty small, straightforward PR, adding support for a new argument-passing syntax in BigQuery. It's called "named arguments" and is similar to keyword arguments in Python.

@barrywhart barrywhart marked this pull request as draft May 28, 2021 20:44
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #1111 (a88a26e) into master (850758d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1111   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         123      123           
  Lines        8176     8181    +5     
=======================================
+ Hits         7849     7854    +5     
  Misses        327      327           
Flag Coverage Δ
dbt017-py38 61.43% <0.00%> (-0.04%) ⬇️
dbt018-py38 61.46% <0.00%> (-0.04%) ⬇️
dbt019-py38 61.46% <0.00%> (-0.04%) ⬇️
py36 94.91% <100.00%> (+<0.01%) ⬆️
py37 94.94% <100.00%> (+<0.01%) ⬆️
py38 94.93% <100.00%> (+<0.01%) ⬆️
py39 94.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_bigquery.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850758d...a88a26e. Read the comment docs.

@barrywhart barrywhart marked this pull request as ready for review May 28, 2021 21:17
@NiallRees NiallRees merged commit a1cbf09 into sqlfluff:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery ST_GEOGFROMGEOJSON breaks parser when using make_valid parameter
2 participants