Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty OVER() clause in Window Specification #1294

Merged

Conversation

tunetheweb
Copy link
Member

Fixes #1293

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #1294 (59f0f86) into main (00fca3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1294   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files         124      124           
  Lines        8609     8609           
=======================================
  Hits         8276     8276           
  Misses        333      333           
Flag Coverage Δ
dbt018-py38 60.68% <ø> (ø)
dbt019-py38 60.68% <ø> (ø)
dbt020-py38 60.64% <ø> (ø)
py36 94.86% <ø> (ø)
py37 94.89% <ø> (ø)
py38 94.88% <ø> (ø)
py39 94.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 99.79% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fca3a...59f0f86. Read the comment docs.

Copy link
Member

@barrywhart barrywhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@barrywhart barrywhart merged commit 3005983 into sqlfluff:main Aug 17, 2021
@tunetheweb tunetheweb mentioned this pull request Aug 17, 2021
@tunetheweb tunetheweb deleted the empty-over-window-specification branch September 21, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty WINDOW specifications are not parsed correctly
2 participants