Bugfix, frame clauses in window functions were not working #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
reviewed
Sep 12, 2021
tunetheweb
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
IGNORE/ RESPECT NULLS were incorrectly in the PostFunctionGrammar, making window functions including them unparsable. This has been fixed. Also made the FrameClauseSegment more explicit, as it's specified in the Redshift docs.
Fixes #1379
Are there any other side effects of this change that we should be aware of?
No. Some test cases now have more explicit Frame Clauses.
Pull Request checklist
Tested, no previous tests have been broken.
Added example in #1379 to Postgres tests, and parses correctly.
Docs link to ANSI and Postgres docs specifying Frame Clause