Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages on error #1407

Merged
merged 4 commits into from
Sep 15, 2021

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Follow on from #1385

Following changes:

  • The current error is not highlighted in red so is a bit lost.
  • Also we only show the error when in verbose mode which I think in hindsight is not great.
  • Should use stderr so anyone using output from stdout can continue to
  • Explain how to override

Are there any other side effects of this change that we should be aware of?

Nope.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/parser (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #1407 (1f78300) into main (178e2a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1407   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          127       127           
  Lines         8553      8550    -3     
=========================================
- Hits          8553      8550    -3     
Impacted Files Coverage Δ
src/sqlfluff/cli/commands.py 100.00% <100.00%> (ø)
src/sqlfluff/rules/L010.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398ed74...1f78300. Read the comment docs.

Copy link
Member

@nolanbconaway nolanbconaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah good call

@tunetheweb tunetheweb merged commit 40b7e6b into sqlfluff:main Sep 15, 2021
@tunetheweb tunetheweb deleted the better-error-messages-on-error branch September 15, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants