TSQL: Remove match possibilities for segments with no TSQL equivalent #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something unusual is going on with UnorderedSelectStatementSegment. It's failing to match on the create_view_with_cte.sql tsql test case when LimitClauseSegment and NamedWindowSegment are redefined to Nothing(), even though neither of those segments actually exists in the test case. Removing those redefines for now, since this is meant to be a simple first PR. |
Codecov Report
@@ Coverage Diff @@
## main #1416 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 127 127
Lines 8583 8603 +20
=========================================
+ Hits 8583 8603 +20
Continue to review full report at Codecov.
|
tunetheweb
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Remapping segments to Nothing() that have no TSQL equivalent. This will keep the linter from pursing paths that include TSQL non-keywords and failing with the runtime error "Grammar refers to 'KeywordSegment' which was not found in the tsql dialect".