Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NORMALIZE to Teradata dialect #1448

Merged
merged 3 commits into from Sep 27, 2021

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #1185

Are there any other side effects of this change that we should be aware of?

Nope. Standard enough dialect enhancement.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/parser (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #1448 (f6da56c) into main (6011bdb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1448   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8795      8804    +9     
=========================================
+ Hits          8795      8804    +9     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_exasol_fs.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_teradata.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4fd2b4...f6da56c. Read the comment docs.

Copy link
Member

@barrywhart barrywhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tunetheweb tunetheweb merged commit 07cd156 into sqlfluff:main Sep 27, 2021
@tunetheweb tunetheweb deleted the add-normalize-to-teradata branch September 27, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[teradata] select normalize not parsing
2 participants