Ignore erroneous newline segments in L016 (e.g. Jinja for loops) #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1494 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 130 130
Lines 8849 9061 +212
==========================================
+ Hits 8849 9061 +212
Continue to review full report at Codecov.
|
tunetheweb
commented
Oct 3, 2021
| @@ -18,7 +18,6 @@ file: | |||
| - newline: "\n" | |||
| - whitespace: ' ' | |||
| - placeholder: '{% for action in actions %}' | |||
| - indent: '' | |||
There was a problem hiding this comment.
Good fix. These indents and dedents are not needed.
barrywhart
approved these changes
Oct 3, 2021
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
…b/sqlfluff into better-jinja-for-loop-handling
tunetheweb
changed the title
|
OK this is just impossible to fix. So I went with the plain and simple option of ignoring newline segments in rule L016. Can you have a look @barrywhart ? |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #1456 by bailing out of checking rule 16 if segment contains a newline (which shouldn't happen but can happen for for loops)
Are there any other side effects of this change that we should be aware of?
Nope. Kept it simple after attempting (and failing!) the complex way.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/parser(note YML files can be auto generated withpython test/generate_parse_fixture_yml.pyor by runningtoxlocally).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.