Fully remove exasol_fs dialect and bump version #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we remove the Can we add a cli test to test for legacy versions? Can we remove the reference in |
|
Need to delete |
Codecov Report
@@ Coverage Diff @@
## main #1573 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 132 -1
Lines 9338 9330 -8
=========================================
- Hits 9338 9330 -8
Continue to review full report at Codecov.
|
tunetheweb
approved these changes
Oct 9, 2021
tunetheweb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1562
This fully removes the
exasol_fsdialect and adds in a removal message. In passing I also make dialect errors red and also bump us to a 0.7.0a1 version in preparation for that release (given I reference being in 0.7.0 in this PR).