Snowflake: Support CURRENT_TIMESTAMP as a column default value #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1578 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9172 9172
=========================================
Hits 9172 9172
Continue to review full report at Codecov.
|
tunetheweb
reviewed
Oct 9, 2021
wong-codaio
force-pushed
the
wong-fix-current-timestamp
branch
from
d178bb2
to
ba9ded1
Compare
|
Looks great. If you could just run |
tunetheweb
approved these changes
Oct 10, 2021
wong-codaio
force-pushed
the
wong-fix-current-timestamp
branch
from
e19bd27
to
ef8cba6
Compare
ttomasz
pushed a commit
to ttomasz/sqlfluff
that referenced
this pull request
Oct 12, 2021
…uff#1578) * Column default value: Support CURRENT_TIMESTAMP Issue sqlfluff#1576 * * Generated `yml` fixture * * Added `SYSDATE()` and `CURRENT_TIMESTAMP` optional precision support * Update src/sqlfluff/dialects/dialect_snowflake.py Co-authored-by: Barry Pollard <barry_pollard@hotmail.com> Co-authored-by: Barry Pollard <barry@tunetheweb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
CURRENT_TIMESTAMPas a column default value in Snowflake dialect.Fixes #1576
Are there any other side effects of this change that we should be aware of?
Not that I'm aware of.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.sql/.ymlparser test cases intest/fixtures/parser(note YML files can be auto generated withpython test/generate_parse_fixture_yml.pyor by runningtoxlocally).