New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow global config for rule testcases #1580
Allow global config for rule testcases #1580
Conversation
…sqlfluff into feature/global-test-conifg
Codecov Report
@@ Coverage Diff @@
## main #1580 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 131 131
Lines 9175 9180 +5
===========================================
+ Hits 9174 9180 +6
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly great. I'd love to add a little more explanation around the test case that you've added, but otherwise excellent. Thanks for putting this together 🚀 .
What’s the use case out of interest? Is this more for custom rules? |
Exactly. We only run Exasol database and all of the custom rules should be tested against this dialect. |
@alanmcruickshank looks like you need to re-review before this can be merged. |
* FIx broken block comments in exasol * Allow adding a global test config per testcase * Respect config per testcase * Allow adding a global test config per testcase * Respect config per testcase * add testcase * make unittest description more meaningful Co-authored-by: Alan Cruickshank <alanmcruickshank@gmail.com> Co-authored-by: Barry Pollard <barry@tunetheweb.com>
Brief summary of the change made
This allows to define a global config (e.g. dialect) per rule test. If a config is defined within a single testcase, this one still respected (behaviour as is).
Example:
While tc1 still uses
ansi
dialect, tc2 and tc3 are usingexasol
dialect...
Are there any other side effects of this change that we should be aware of?
...
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/parser
(note YML files can be auto generated withpython test/generate_parse_fixture_yml.py
or by runningtox
locally).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.