New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename keyword files #1584
Rename keyword files #1584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion for a possibly cleaner way to organize things. Looks good overall.
I see the linter is failing.
Codecov Report
@@ Coverage Diff @@
## main #1584 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9175 9175
=========================================
Hits 9175 9175
Continue to review full report at Codecov.
|
* Rename keyword files * Linting fixes * Test update * Linting fixes Co-authored-by: Alan Cruickshank <alanmcruickshank@gmail.com>
Brief summary of the change made
Makes progress on #1575 by renaming dialect keyword files so they are listed besides their dialects in code editors and the like.
Are there any other side effects of this change that we should be aware of?
Could be some merge conflicts if anyone is working on changing these files but looks quiet at the mo so good time to do it!
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/parser
(note YML files can be auto generated withpython test/generate_parse_fixture_yml.py
or by runningtox
locally).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.