Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more unreserved keywords to BigQuery #1588

Merged
merged 3 commits into from Oct 11, 2021

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #1587

Added unreserved words that we use in ANSI so might use in BigQuery.

Are there any other side effects of this change that we should be aware of?

Nope.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/parser (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #1588 (9978cc5) into main (8b5e89d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1588   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          131       131           
  Lines         9175      9175           
=========================================
  Hits          9175      9175           
Impacted Files Coverage Δ
src/sqlfluff/dialects/bigquery_keywords.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5e89d...9978cc5. Read the comment docs.

@tunetheweb tunetheweb merged commit 673c314 into sqlfluff:main Oct 11, 2021
ttomasz pushed a commit to ttomasz/sqlfluff that referenced this pull request Oct 12, 2021
Co-authored-by: Alan Cruickshank <alanmcruickshank@gmail.com>
@tunetheweb tunetheweb deleted the more-bigquery-unresered-keywords branch June 23, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: Exception on ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW
3 participants