New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake: Add implementation for CREATE TASK statement (#1597) #1603
Snowflake: Add implementation for CREATE TASK statement (#1597) #1603
Conversation
372abe7
to
8450623
Compare
@tunetheweb, here is the PR. maybe you can help me out with the questions above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
Feedback below:
BTW run this to generate the YML file from the SQL fixtures:
|
3cdf37a
to
66421a9
Compare
66421a9
to
cfbd222
Compare
Codecov Report
@@ Coverage Diff @@
## main #1603 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9180 9184 +4
=========================================
+ Hits 9180 9184 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This good to merge now or still working on it?
That would be good from my side. I still have some other failures, but those are unrelated so that will be a new PR in the next days probably |
Thank you! Hopefully this PR has encouraged you to (or at least hasn't discouraged you from!) adding more PRs |
Brief summary of the change made
Closes #1597
This PR adds an implementation for the
CREATE TASK
expression for the Snowflake dialect as described in the docsOpen questions/issues:
WHEN
clause?SCHEDULE
clause is implemented as literal string, not broken down furtherStatementSegment
for theAS
clause correct?