Snowflake: Fixed data type casting not working in SET statement
#1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1604 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 9180 9180
=========================================
Hits 9180 9180
Continue to review full report at Codecov.
|
tunetheweb
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Approved.
Added this to the "Are there any other side effects of this change that we should be aware of?" section of the initial comment:
Changing the ANSI definition, rather than implementing in Snowflake dialect but think that's OK as other casting in ANSI.
Always good to point out when might be side effects.
ttomasz
pushed a commit
to ttomasz/sqlfluff
that referenced
this pull request
Oct 12, 2021
…lfluff#1604) Fixes sqlfluff#1601 Co-authored-by: Barry Pollard <barry@tunetheweb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #1601
Are there any other side effects of this change that we should be aware of?
Changing the ANSI definition, rather than implementing in Snowflake dialect but think that's OK as other casting in ANSI.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withpython test/generate_parse_fixture_yml.pyor by runningtoxlocally).