Segregate dbt plugin tests #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1610 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 133
Lines 9250 9250
=========================================
Hits 9250 9250 Continue to review full report at Codecov.
|
tunetheweb
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
These changes look fine.
Can you update line 158 of CONTRIBUTING.md too?
@barrywhart any thoughts from the Python side?
CyberShadow
pushed a commit
to CyberShadow/sqlfluff
that referenced
this pull request
Oct 14, 2021
* Segregate dbt plugin tests * linting * update contributing.md Co-authored-by: Barry Pollard <barry@tunetheweb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the thread of segregating the dbt plugin.
It migrates any of the dbt tests into the plugin directory. They remain part of the standard test suite, but the connection between sqlfluff core and the dbt templater would now be complete, where all dbt related code is housed in the plugin.
In the process it changes how we call the dbt and plugin tests. Rather than using
mark(and therefore-m "dbt"or-m "not dbt"), but instead we now point at the directory housing the tests (eithertestorplugins/sqlfluff-templater-dbt).I hope this sets the stage for other plugins which we either house within the core repo, or that people might want to use as a template for other plugins.