New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better date function for tsql #1636
Better date function for tsql #1636
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1636 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 133
Lines 9243 9247 +4
=========================================
+ Hits 9243 9247 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One question about potentially adding an additional test.
…fluff into better-date-function-tsql
…fluff into better-date-function-tsql
Brief summary of the change made
Fixes #1623
Are there any other side effects of this change that we should be aware of?
Renames
DateAddFunctionNameSegment
toDatePartFunctionNameSegment
better reflect it might be used for more than justDATEADD
.Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withpython test/generate_parse_fixture_yml.py
or by runningtox
locally).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.