Stop rule L048 complaining if literal is followed by a semicolon #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the end of the statement
Codecov Report
@@ Coverage Diff @@
## main #1638 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 133
Lines 9250 9250
=========================================
Hits 9250 9250
Continue to review full report at Codecov.
|
barrywhart
previously requested changes
Oct 14, 2021
…lfluff into update-l048-for-semicolons
alanmcruickshank
approved these changes
Oct 14, 2021
|
@barrywhart need you to approve before this can be merged. @alanmcruickshank is there anyway to relax that rule? While I agree the original reviewer SHOULD re-review, don't think this needs to be a MUST? As it blocks it as in this case where we have another reviewer's sign off |
|
@tunetheweb I've updated the settings so that maintainers can dismiss reviews. Does that enable you to do that now? |
CyberShadow
pushed a commit
to CyberShadow/sqlfluff
that referenced
this pull request
Oct 14, 2021
…fluff#1638) * Stop rule L048 complaining if literal is followed by a semicolon for the end of the statement * Linting * Review feedback Co-authored-by: Alan Cruickshank <alanmcruickshank@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #1626
Are there any other side effects of this change that we should be aware of?
Nope. Fairly easy one this.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withpython test/generate_parse_fixture_yml.pyor by runningtoxlocally).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.