Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Redshift support #1641

Merged
merged 3 commits into from Oct 14, 2021

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Oct 13, 2021

Brief summary of the change made

Adds initial Redshift support as had a few queries on it.
It inherits form Postgres but gets:

Fixes #612
Fixes #1629
Progress on #1623

Are there any other side effects of this change that we should be aware of?

Based off of Postgres for now as, according to Wikipedia:

Amazon Redshift is based on an older version of PostgreSQL 8.0.2, and Redshift has made changes to that version.
Plus most redshift users have been using that dialect up to now.
Will need to try our best to manage any differences (ideally just override in Redshift dialect rather than introduce too much non-Postgres stuff to that dialect).

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1641 (95a3bba) into main (ed23bf6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1641   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          131       133    +2     
  Lines         9223      9243   +20     
=========================================
+ Hits          9223      9243   +20     
Impacted Files Coverage Δ
src/sqlfluff/core/dialects/__init__.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_redshift.py 100.00% <100.00%> (ø)
src/sqlfluff/dialects/dialect_redshift_keywords.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed23bf6...95a3bba. Read the comment docs.

@WittierDinosaur
Copy link
Contributor

Looks good to me! LGTM

@WittierDinosaur WittierDinosaur merged commit 8619f79 into sqlfluff:main Oct 14, 2021
@tunetheweb tunetheweb deleted the redshift-dialect branch June 23, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore null causes parsing error for Redshift AWS Redshift Dialect support
2 participants