TSQL: Allow DECLARE/SET statements to parse using ExpressionStatement #1649
+83
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
approved these changes
Oct 14, 2021
Codecov Report
@@ Coverage Diff @@
## main #1649 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 133
Lines 9251 9250 -1
=========================================
- Hits 9251 9250 -1
Continue to review full report at Codecov.
|
CyberShadow
pushed a commit
to CyberShadow/sqlfluff
that referenced
this pull request
Oct 14, 2021
…sqlfluff#1649) * Fix TSQL DECLARE and SET statements to fully parse expression assignments * Fix TSQL DECLARE and SET statements to fully parse expression assignments Co-authored-by: jpersons <jpersons@iuhealth.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSQL DECLARE and SET statements can have full expressions as the value to be assigned, but the parsers for each did not cover all possibilities. I have simplified both of these by replacing the right side of the assignment statement with ExpressionStatement.
I'm not sure why this wasn't the situation already, so I may be missing something, but I found no test cases or documentation to explain the decision. I have update our test cases to cover a couple valid scenarios which were previously unparseable. Two additional test cases had their YAML updated slightly.