New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add missing init file to sqlfluff.core.templaters.slicers
#1826
Conversation
I just noticed that 1788 adds this file, but IMHO this quick fix can be isolated into a small PR and then merge those changes, so that |
Codecov Report
@@ Coverage Diff @@
## main #1826 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 138 138
Lines 9832 9832
=========================================
Hits 9832 9832
Continue to review full report at Codecov.
|
Can you add the comment like #1788 does to prevent linting failures. @barrywhart you happy for this to go ahead of your PR? |
Sure, go ahead. Not sure when mine will be finished. |
Added! @barrywhart I couldn't find a way to checkout the file from your fork so that it appeared as authored by you, sorry. |
No worries! |
Perhaps it's worth adding a test case for this? |
@WittierDinosaur do you mean testing the CLI or testing imports? |
Presume he means to prevent this issue happening again in the future where a new module is added without a Would be good if we could add that. But think out of scope of this PR so let's merge this. |
Brief summary of the change made
Running
sqlfluff --help
(or any CLI command) fails withModuleNotFoundError: No module named 'sqlfluff.core.templaters.slicers'
due to a missing__init__.py
file onsrc/sqlfluff/core/templaters/slicers
.Are there any other side effects of this change that we should be aware of?
None