Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_install to static analysis sections of tox.ini #1851

Merged
merged 1 commit into from Nov 8, 2021
Merged

Add skip_install to static analysis sections of tox.ini #1851

merged 1 commit into from Nov 8, 2021

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Nov 8, 2021

Brief summary of the change made

Very simple PR. We are currently installing the sqlfluff package into our linting,doclinting, and mypy tox environments. These are all static analysis tools and hence don't need the package installed to run.
We therefore add skip_install=True to these sections.
Approach is used in many other projects (e.g. flake8 https://github.com/PyCQA/flake8/blob/main/tox.ini)

Are there any other side effects of this change that we should be aware of?

No as mentioned above these tox environments aren't actually touching the package.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@tunetheweb tunetheweb changed the title added skip_install to static analysis sections of tox.ini Add skip_install to static analysis sections of tox.ini Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #1851 (b7ef2f0) into main (f038781) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1851   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          139       139           
  Lines         9946      9946           
=========================================
  Hits          9946      9946           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f038781...b7ef2f0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants