New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tox publish commands #1853
Add Tox publish commands #1853
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1853 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 141 141
Lines 10038 10038
=========================================
Hits 10038 10038 Continue to review full report at Codecov.
|
@alanmcruickshank , could you also take a quick look at this PR too please? Goal is to use more modern python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for putting this together - I haven't been very good at staying on top of the latest package building best practices 👍
Brief summary of the change made
Added tox commands relating to the building and publishing of the package to streamline release workflows.
Also updated build step to use the build package as detailed here.
Are there any other side effects of this change that we should be aware of?
This should be a pretty straight swap.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withpython test/generate_parse_fixture_yml.py
or by runningtox
locally).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.