Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tox publish commands #1853

Merged
merged 9 commits into from Nov 14, 2021
Merged

Add Tox publish commands #1853

merged 9 commits into from Nov 14, 2021

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Nov 9, 2021

Brief summary of the change made

Added tox commands relating to the building and publishing of the package to streamline release workflows.
Also updated build step to use the build package as detailed here.

Are there any other side effects of this change that we should be aware of?

This should be a pretty straight swap.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1853 (c05f930) into main (5fa269c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1853   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines        10038     10038           
=========================================
  Hits         10038     10038           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa269c...c05f930. Read the comment docs.

@jpy-git
Copy link
Contributor Author

jpy-git commented Nov 13, 2021

@alanmcruickshank , could you also take a quick look at this PR too please? Goal is to use more modern python build command and start centralising commands in the tox configuration 😄

Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for putting this together - I haven't been very good at staying on top of the latest package building best practices 👍

@alanmcruickshank alanmcruickshank merged commit f525699 into sqlfluff:main Nov 14, 2021
@jpy-git jpy-git deleted the tox_publish_commands branch November 18, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants