Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres: Allow use of quoted identifiers to ALTER TABLE OWNER TO #1856

Merged
merged 3 commits into from Nov 9, 2021

Conversation

markpolyak
Copy link
Contributor

@markpolyak markpolyak commented Nov 9, 2021

Brief summary of the change made

Fixes #1854

Are there any other side effects of this change that we should be aware of?

Not that I'm aware of.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@markpolyak markpolyak changed the title Allow use quoted identifiers in postgres ALTER TABLE OWNER TO Allow use of quoted identifiers in postgres ALTER TABLE OWNER TO Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1856 (5092417) into main (b4ce836) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1856   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          139       139           
  Lines         9946      9946           
=========================================
  Hits          9946      9946           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_postgres.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ce836...5092417. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tunetheweb tunetheweb merged commit a527a4d into sqlfluff:main Nov 9, 2021
@tunetheweb tunetheweb changed the title Allow use of quoted identifiers in postgres ALTER TABLE OWNER TO Postgres: Allow use of quoted identifiers to ALTER TABLE OWNER TO Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser error caused by quoted identifier in ALTER TABLE ... OWNER TO
2 participants