Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L036 docstring refinements #1903

Merged
merged 2 commits into from Nov 14, 2021
Merged

L036 docstring refinements #1903

merged 2 commits into from Nov 14, 2021

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Nov 14, 2021

Brief summary of the change made

The previous docstring for L036 didn't provide a clear example of the action of the rule. This should resolve that.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #1903 (22af0e7) into main (f525699) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1903   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines        10038     10038           
=========================================
  Hits         10038     10038           
Impacted Files Coverage Δ
src/sqlfluff/rules/L036.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f525699...22af0e7. Read the comment docs.

@tunetheweb tunetheweb merged commit 7ef77d2 into sqlfluff:main Nov 14, 2021
@jpy-git jpy-git deleted the L036_docstring branch November 18, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants