Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres & T-SQL: Drop Function #1924

Merged
merged 7 commits into from Nov 19, 2021

Conversation

WittierDinosaur
Copy link
Contributor

@WittierDinosaur WittierDinosaur commented Nov 17, 2021

Brief summary of the change made

Adds Drop Function support to Postgres & T-SQL

Fixes #1908

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

Tests & docstrings added

@WittierDinosaur
Copy link
Contributor Author

Slightly mangled commit history from forgetting to pull from upstream 🤦‍♂️

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #1924 (b491de3) into main (4d628b3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1924   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          143       143           
  Lines        10152     10160    +8     
=========================================
+ Hits         10152     10160    +8     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_postgres.py 100.00% <100.00%> (ø)
src/sqlfluff/dialects/dialect_tsql.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d628b3...b491de3. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tunetheweb tunetheweb merged commit 7a391c8 into sqlfluff:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Function Support
2 participants