Fix subquery bug in L026

[jpy-git]

Brief summary of the change made

This PR fixes bug in L026 in which table references within subqueries were incorrectly being identified as not being found. Fixes #1939.

On investigating I found the cause was the references returned from get_select_statement_info incorrectly included references from subqueries. There was already some logic in get_select_statement_info to handle this but was in the wrong place in the function. I have moved this logic to the end of the function and added extra unit tests to all rules which utilise get_select_statement_info to provide additional validation.

Are there any other side effects of this change that we should be aware of?

Not that I'm aware of, I've added additional unit tests to be sure that other rules aren't impacted.

Pull Request checklist

• Please confirm you have completed any of the necessary steps below.

• Included test cases to demonstrate any code changes, which may be one or more of the following:

  • .yml rule test cases in test/fixtures/rules/std_rule_cases.
  • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
  • Full autofix test cases in test/fixtures/linter/autofix.
  • Other.

• Added appropriate documentation for the change.

• Created GitHub issues for any relevant followup/future enhancements if appropriate.

[tunetheweb]

LGTM if the tests pass.

@pwildenhain too late to get into 0.8.2? Will let you merge if you're happy to include. If not will merge after.

[codecov]

Codecov Report

Merging #1948 (e162c65) into main (14f93b3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1948   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          147       147           
  Lines        10219     10219           
=========================================
  Hits         10219     10219           

Impacted Files	Coverage Δ
src/sqlfluff/core/rules/analysis/select.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f93b3...e162c65. Read the comment docs.

[tunetheweb]

Does this fix #1462 as well out of interest?

Happy to merge as is but thought worth asking if it does, or if it’s related and could be made to, before I merge.

[jpy-git]

Will take a look into it 👀

[jpy-git]

@tunetheweb I've checked and no it doesn't seem to impact that issue so I think we can consider it out of scope for this PR. Let's merge this one in and then happy to investigate the other issue further seperately 😄