New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rule to flag special characters in identifiers #1958
New rule to flag special characters in identifiers #1958
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1958 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 147 148 +1
Lines 10284 10300 +16
=========================================
+ Hits 10284 10300 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few quick tweaks whilst i look through the rule logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpers36 a couple suggestions formatting wise, plus note on typing, and extra unit tests suggestions.
For the most part its looking great! 💪
(always find it a bit mad that sql allows these non alnum characters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🥇
@barrywhart I don't have write access so can't approve. I've looked over the code and all feedback has been addressed so can you take a quick look over and if there's nothing else to add then approve and merge 😄 |
Fixes #1746
Brief summary of the change made
A new linting rule: flag special characters in identifiers.
If an identifier includes a character other than alphanumeric or underscore, this rule will flag it.
This rule includes configuration settings to control which types of identifiers fall under the rule.
This rule also includes a configuration setting to allow or disallow spaces as part of an identifier.
+L057 python script
+L057 test YAML
+L057 configuration defaults
+allow_space_in_identifier description in config_info.py