Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L027: Remove unnessary crawl in get_select_statement_info #1974

Merged
merged 2 commits into from Nov 25, 2021
Merged

L027: Remove unnessary crawl in get_select_statement_info #1974

merged 2 commits into from Nov 25, 2021

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Nov 24, 2021

Brief summary of the change made

Resolves #1973. Please, refer to the issue for description of fix.

N.B. some reason L027 was inheriting from L025 (which in turn inherits from L020) even though L025 provides no extra logic, I have corrected this to inherit from L020.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #1974 (4ef9895) into main (1cb0be5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1974   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines        10291     10290    -1     
=========================================
- Hits         10291     10290    -1     
Impacted Files Coverage Δ
src/sqlfluff/core/rules/analysis/select.py 100.00% <ø> (ø)
src/sqlfluff/rules/L027.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb0be5...4ef9895. Read the comment docs.

@WittierDinosaur WittierDinosaur merged commit 3bca62f into sqlfluff:main Nov 25, 2021
@jpy-git jpy-git deleted the l027_wildcard_double_count branch November 25, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L027 double raised with wildcard
2 participants