New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config.get for iterable sections #2020
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e2e6105
Fix config.get for iterable segments
jpy-git 2b32aa7
Add unit tests for coverage
jpy-git c0652d0
Merge branch 'main' into config_get
jpy-git f5fc9f6
Lint fixes
jpy-git 5cc09bc
Merge branch 'main' into config_get
jpy-git 2e25f0b
Merge branch 'main' into config_get
jpy-git File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -615,7 +615,11 @@ def get( | |
self, val: str, section: Union[str, Iterable[str]] = "core", default: Any = None | ||
): | ||
"""Get a particular value from the config.""" | ||
return self._configs[section].get(val, default) | ||
section_dict = self.get_section(section) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. handles nested config sections |
||
if section_dict is None: | ||
return default | ||
Comment on lines
+619
to
+620
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. returns default if the section doesn't exist. Could alternatively raise a KeyError if preferred. Fine either way |
||
|
||
return section_dict.get(val, default) | ||
|
||
def get_section(self, section: Union[str, Iterable[str]]) -> Union[dict, None]: | ||
"""Return a whole section of config as a dict. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would only work for if session a str