Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar: Add DROP POLICY statement to postgres dialect #2024

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Grammar: Add DROP POLICY statement to postgres dialect #2024

merged 2 commits into from
Dec 2, 2021

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Dec 2, 2021

Brief summary of the change made

Fixes #2015. Adds DROP POLICY statement to the postgres dialect. (CREATE POLICY was added in #2021)

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #2024 (0103028) into main (a4973fe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2024   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines        10374     10379    +5     
=========================================
+ Hits         10374     10379    +5     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_postgres.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4973fe...0103028. Read the comment docs.

@jpy-git jpy-git merged commit 2dbeafa into sqlfluff:main Dec 2, 2021
@jpy-git jpy-git deleted the postgres_drop_policy branch December 2, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create/Drop Policy Support
2 participants