Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameters for Snowflake create tasks statement #2037

Conversation

chwiese
Copy link
Contributor

@chwiese chwiese commented Dec 5, 2021

Brief summary of the change made

Fixes options for the CREATE TASK statement in the Snowflake dialect:

  • One can only specify the WAREHOUSE parameter or the USER_TASK_MANAGED_INITIAL_WAREHOUSE_SIZE parameter, but not both
  • The parameters can be in arbitrary order, except for AFTER which must be last
  • The value for USER_TASK_MANAGED_INITIAL_WAREHOUSE_SIZE is a warehouse size, not a quoted literal. Warehouse sizes themselves are not identifiers, so I am changing the type of that RegexParser.
  • The quotes around the warehouse sizes are optional, except for the ones with hyphens, which must be quoted. The same rules apply the CREATE WAREHOUSE statements, even if that is not clearly documented there.

Are there any other side effects of this change that we should be aware of?

None.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #2037 (2b886dc) into main (0f8d2c1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2037   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines        10495     10495           
=========================================
  Hits         10495     10495           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8d2c1...2b886dc. Read the comment docs.

Copy link
Contributor

@jpy-git jpy-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chwiese very small tweak to remove the unnecessary default delimiter, but otherwise perfect and will approve and merge after once that line is removed ⭐

src/sqlfluff/dialects/dialect_snowflake.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jpy-git jpy-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done @chwiese 🚀 🌟

@jpy-git jpy-git merged commit 42b142e into sqlfluff:main Dec 6, 2021
@chwiese chwiese deleted the Fix-parameters-for-Snowflake-create-task-statement branch December 11, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants