CLI: Add --ignore-local-config flag #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpy-git
changed the title
|
@barrywhart @tunetheweb this option allows for non-override behaviour when specifying the config via the CLI 👍 Looking to get this + the config simple API option finished before the next release |
Codecov Report
@@ Coverage Diff @@
## main #2061 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 148 148
Lines 10508 10510 +2
=========================================
+ Hits 10508 10510 +2
Continue to review full report at Codecov.
|
tunetheweb
approved these changes
Dec 8, 2021
|
@tunetheweb yeah it's definitely something to look into. Most of the lines in this and #1986 are because they're specifically to do with loading the config. Most other config changes should be fairly lightweight 😄 |
This was referenced Dec 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
This is a follow up to #1986 (The code changes are near identical, just for a different flag).
This PR adds a
--ignore-local-configflag to the CLI that serves 2 main purposes:--configflag the user is able to use a custom config without the local config override behaviour.The idea was from a discussion with @tunetheweb when making the original PR.
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withpython test/generate_parse_fixture_yml.pyor by runningtoxlocally).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.