Fix L022 to not flag CTE column definitions

[jpy-git]

Brief summary of the change made

Fixes #2136. L022 currently uses closing bracket to find the end of a CTE. This is fine for most cases but unintentionally flags CTE column definitions as described in the linked issue. Fix is simple: Check that the preceding keyword to the bracketed segment is AS 👌

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

• Please confirm you have completed any of the necessary steps below.

• Included test cases to demonstrate any code changes, which may be one or more of the following:

  • .yml rule test cases in test/fixtures/rules/std_rule_cases.
  • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
  • Full autofix test cases in test/fixtures/linter/autofix.
  • Other.

• Added appropriate documentation for the change.

• Created GitHub issues for any relevant followup/future enhancements if appropriate.

[codecov]

Codecov Report

Merging #2139 (7022f95) into main (0b58b83) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #2139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines        10677     10679    +2     
=========================================
+ Hits         10677     10679    +2     

Impacted Files	Coverage Δ
src/sqlfluff/rules/L022.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b58b83...7022f95. Read the comment docs.

[barrywhart]

Looks good! 👍

[tunetheweb]

It looks related but slightly different.

This issue fixed the original test case, and also fixes yours if the (var) is set on cte_1 but not for cte_2.

Let's keep this closed, and can you open a new issue for that? Link to this PR in that.