Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set dbt_modules to dbt_packages #2143

Merged
merged 3 commits into from Dec 20, 2021
Merged

docs: set dbt_modules to dbt_packages #2143

merged 3 commits into from Dec 20, 2021

Conversation

ciklista
Copy link
Contributor

@ciklista ciklista commented Dec 20, 2021

Brief summary of the change made

The default name for the packages folder is dbt_packages since dbt v1.0.0 (see dbt-labs/dbt-core#3523)

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with python test/generate_parse_fixture_yml.py or by running tox locally).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

The default name for the packages folder is `dbt_packages` since dbt v1.0.0 (see dbt-labs/dbt-core#3523)
Copy link
Contributor

@jpy-git jpy-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Couple quick changes to make 😄

docs/source/configuration.rst Show resolved Hide resolved
ciklista and others added 2 commits December 20, 2021 13:44
Co-authored-by: Joseph Young <80432516+jpy-git@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #2143 (d938f0e) into main (897fba8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines        10679     10679           
=========================================
  Hits         10679     10679           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897fba8...d938f0e. Read the comment docs.

Copy link
Contributor

@jpy-git jpy-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciklista Looks good, thanks for adding this 😄 LGTM 🚀 ⭐

@jpy-git jpy-git merged commit 1ad0ceb into sqlfluff:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants