Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar: Tidy up Snowflake/MySQL/HIVE USE statements #2187

Merged
merged 8 commits into from Dec 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 3 additions & 15 deletions src/sqlfluff/dialects/dialect_ansi.py
Expand Up @@ -3095,24 +3095,12 @@ class DescribeStatementSegment(BaseSegment):

@ansi_dialect.segment()
class UseStatementSegment(BaseSegment):
"""A `USE` statement.

USE [ ROLE ] <name>

USE [ WAREHOUSE ] <name>

USE [ DATABASE ] <name>

USE [ SCHEMA ] [<db_name>.]<name>
"""
"""A `USE` statement."""

type = "use_statement"
match_grammar = StartsWith("USE")

parse_grammar = Sequence(
match_grammar = Sequence(
"USE",
OneOf("ROLE", "WAREHOUSE", "DATABASE", "SCHEMA", optional=True),
Ref("ObjectReferenceSegment"),
Ref("DatabaseReferenceSegment"),
)


Expand Down
11 changes: 0 additions & 11 deletions src/sqlfluff/dialects/dialect_hive.py
Expand Up @@ -496,17 +496,6 @@ class TruncateStatementSegment(BaseSegment):
)


@hive_dialect.segment(replace=True)
class UseStatementSegment(BaseSegment):
"""An `USE` statement."""

type = "use_statement"
match_grammar = Sequence(
"USE",
Ref("DatabaseReferenceSegment"),
)


@hive_dialect.segment(replace=True)
class StatementSegment(ansi_dialect.get_segment("StatementSegment")): # type: ignore
"""Overriding StatementSegment to allow for additional segment parsing."""
Expand Down
34 changes: 33 additions & 1 deletion src/sqlfluff/dialects/dialect_snowflake.py
Expand Up @@ -539,7 +539,6 @@ class StatementSegment(ansi_dialect.get_segment("StatementSegment")): # type: i

parse_grammar = ansi_dialect.get_segment("StatementSegment").parse_grammar.copy(
insert=[
Ref("UseStatementSegment"),
Ref("CreateStatementSegment"),
Ref("CreateTaskSegment"),
Ref("CreateCloneStatementSegment"),
Expand Down Expand Up @@ -3519,3 +3518,36 @@ class CommentStatementSegment(BaseSegment):
"IS",
Ref("QuotedLiteralSegment"),
)


@snowflake_dialect.segment(replace=True)
class UseStatementSegment(BaseSegment):
"""A `USE` statement.

https://docs.snowflake.com/en/sql-reference/sql/use.html
"""

type = "use_statement"
match_grammar = Sequence(
"USE",
OneOf(
Sequence("ROLE", Ref("ObjectReferenceSegment")),
Sequence("WAREHOUSE", Ref("ObjectReferenceSegment")),
Sequence(
Ref.keyword("DATABASE", optional=True),
Ref("DatabaseReferenceSegment"),
),
Sequence(
Ref.keyword("SCHEMA", optional=True),
Ref("SchemaReferenceSegment"),
),
Sequence(
"SECONDARY",
"ROLES",
OneOf(
"ALL",
"NONE",
),
),
),
)
1 change: 1 addition & 0 deletions src/sqlfluff/dialects/dialect_snowflake_keywords.py
Expand Up @@ -328,6 +328,7 @@
SCHEDULE
SCHEMAS
SECOND
SECONDARY
SECURE
SECURITY
SEED
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/dialects/mysql/use_database.yml
Expand Up @@ -3,11 +3,11 @@
# computed by SQLFluff when running the tests. Please run
# `python test/generate_parse_fixture_yml.py` to generate them after adding or
# altering SQL files.
_hash: 33fd349f0a269928e8467c2d5e344540bd7451fd757a92fc2497cf14c1dea31a
_hash: 0a7521fef2b73d430f586f5eb3db1363de28f5d740a86a1a4644f0fb7f289566
file:
statement:
use_statement:
keyword: use
object_reference:
database_reference:
identifier: my_db
statement_terminator: ;
1 change: 1 addition & 0 deletions test/fixtures/dialects/mysql/use_statement.sql
@@ -0,0 +1 @@
USE db;
13 changes: 13 additions & 0 deletions test/fixtures/dialects/mysql/use_statement.yml
@@ -0,0 +1,13 @@
# YML test files are auto-generated from SQL files and should not be edited by
# hand. To help enforce this, the "hash" field in the file must match a hash
# computed by SQLFluff when running the tests. Please run
# `python test/generate_parse_fixture_yml.py` to generate them after adding or
# altering SQL files.
_hash: 2224c350cd615fa21509176099d7565e9e369a63294787cea56a3010591bcedc
file:
statement:
use_statement:
keyword: USE
database_reference:
identifier: db
statement_terminator: ;
4 changes: 4 additions & 0 deletions test/fixtures/dialects/snowflake/snowflake_use.sql
Expand Up @@ -19,3 +19,7 @@ USE SCHEMA "MY_DATABASE"."MY_SCHEMA";
USE SCHEMA "MY_SCHEMA";

USE "MY_DATABASE"."MY_SCHEMA";

USE SECONDARY ROLES ALL;

USE SECONDARY ROLES NONE;
30 changes: 22 additions & 8 deletions test/fixtures/dialects/snowflake/snowflake_use.yml
Expand Up @@ -3,7 +3,7 @@
# computed by SQLFluff when running the tests. Please run
# `python test/generate_parse_fixture_yml.py` to generate them after adding or
# altering SQL files.
_hash: ac5358b10e8c24fcb3d4d780a0a7926c3d2499f6cf85759aa9610a217e5a2dba
_hash: 304ece91d8540fd10a09ebec75402ff76d951690615eac803dee97975aa9c73f
file:
- statement:
use_statement:
Expand All @@ -23,14 +23,14 @@ file:
use_statement:
- keyword: use
- keyword: database
- object_reference:
- database_reference:
identifier: my_database
- statement_terminator: ;
- statement:
use_statement:
- keyword: use
- keyword: schema
- object_reference:
- schema_reference:
identifier: my_schema
- statement_terminator: ;
- statement:
Expand All @@ -51,20 +51,20 @@ file:
use_statement:
- keyword: USE
- keyword: DATABASE
- object_reference:
- database_reference:
identifier: '"MY_DATABASE"'
- statement_terminator: ;
- statement:
use_statement:
keyword: USE
object_reference:
database_reference:
identifier: '"MY_DATABASE"'
- statement_terminator: ;
- statement:
use_statement:
- keyword: USE
- keyword: SCHEMA
- object_reference:
- schema_reference:
- identifier: '"MY_DATABASE"'
- dot: .
- identifier: '"MY_SCHEMA"'
Expand All @@ -73,14 +73,28 @@ file:
use_statement:
- keyword: USE
- keyword: SCHEMA
- object_reference:
- schema_reference:
identifier: '"MY_SCHEMA"'
- statement_terminator: ;
- statement:
use_statement:
keyword: USE
object_reference:
database_reference:
- identifier: '"MY_DATABASE"'
- dot: .
- identifier: '"MY_SCHEMA"'
- statement_terminator: ;
- statement:
use_statement:
- keyword: USE
- keyword: SECONDARY
- keyword: ROLES
- keyword: ALL
- statement_terminator: ;
- statement:
use_statement:
- keyword: USE
- keyword: SECONDARY
- keyword: ROLES
- keyword: NONE
- statement_terminator: ;