Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar: Tidy up transaction statements in Snowflake dialect #2196

Merged
merged 3 commits into from Dec 26, 2021
Merged

Grammar: Tidy up transaction statements in Snowflake dialect #2196

merged 3 commits into from Dec 26, 2021

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Dec 24, 2021

Brief summary of the change made

The TransactionStatementSegment in ANSI allows for extra Postgres specific grammar not valid in the Snowflake dialect therefore I've overwritten the segment in the Snowflake dialect.

Will follow up in a separate PR to tidy up Postgres transactions statements as well.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #2196 (3894b03) into main (909bd57) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines        10759     10762    +3     
=========================================
+ Hits         10759     10762    +3     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909bd57...3894b03. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tunetheweb tunetheweb merged commit 212432f into sqlfluff:main Dec 26, 2021
@jpy-git jpy-git deleted the snowflake_transaction_statements branch December 26, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants