Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Make code blocks consistent #2242

Merged
merged 3 commits into from Jan 6, 2022
Merged

Docs: Make code blocks consistent #2242

merged 3 commits into from Jan 6, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Jan 6, 2022

Brief summary of the change made

In a lot of places in the docs we're marking code blocks as bash even though they contain command output as well as the console commands, resulting in weird highlighting:
image

image

This PR converts these blocks to text to avoid this.

Additionally I've made cfg blocks consistent and specified the blocks missing a marker.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #2242 (98ade3e) into main (9306a2c) will increase coverage by 42.27%.
The diff coverage is n/a.

❗ Current head 98ade3e differs from pull request most recent head 582052b. Consider uploading reports for the commit 582052b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             main     #2242       +/-   ##
============================================
+ Coverage   57.72%   100.00%   +42.27%     
============================================
  Files         156       156               
  Lines       11057     11075       +18     
============================================
+ Hits         6383     11075     +4692     
+ Misses       4674         0     -4674     
Impacted Files Coverage Δ
src/sqlfluff/core/parser/grammar/conditional.py 100.00% <ø> (ø)
src/sqlfluff/core/dialects/base.py 100.00% <0.00%> (+1.20%) ⬆️
src/sqlfluff/dialects/dialect_ansi.py 100.00% <0.00%> (+1.21%) ⬆️
src/sqlfluff/core/parser/markers.py 100.00% <0.00%> (+1.42%) ⬆️
src/sqlfluff/core/rules/functional/segments.py 100.00% <0.00%> (+2.56%) ⬆️
src/sqlfluff/rules/L023.py 100.00% <0.00%> (+3.44%) ⬆️
src/sqlfluff/dialects/dialect_postgres_keywords.py 100.00% <0.00%> (+4.00%) ⬆️
src/sqlfluff/core/parser/grammar/anyof.py 100.00% <0.00%> (+4.21%) ⬆️
src/sqlfluff/core/templaters/base.py 100.00% <0.00%> (+5.17%) ⬆️
src/sqlfluff/rules/L050.py 100.00% <0.00%> (+5.26%) ⬆️
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9306a2c...582052b. Read the comment docs.

docs/source/configuration.rst Show resolved Hide resolved
@jpy-git jpy-git merged commit c5cc560 into sqlfluff:main Jan 6, 2022
@jpy-git jpy-git deleted the docs_code_blocks branch January 6, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants