Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake: Add support for column rename #2327

Merged
merged 1 commit into from Jan 17, 2022

Conversation

wong-codaio
Copy link
Contributor

@wong-codaio wong-codaio commented Jan 17, 2022

Brief summary of the change made

Snowflake: Add support for column rename

fixes #2206

Are there any other side effects of this change that we should be aware of?

  • None that I can think of.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).

@wong-codaio wong-codaio marked this pull request as ready for review January 17, 2022 03:06
@wong-codaio
Copy link
Contributor Author

@tunetheweb @jpy-git - FYI - The 2nd step in the plan to get Snowflake's ALTER TABLE tableColumnAction implemented per #2206 (comment).

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #2327 (a7328f6) into main (0ea874b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2327   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          159       159           
  Lines        11295     11295           
=========================================
  Hits         11295     11295           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea874b...a7328f6. Read the comment docs.

Copy link
Contributor

@jpy-git jpy-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wong-codaio nice work, looks great! LGTM 🚀 ✨

@jpy-git jpy-git merged commit 145f490 into sqlfluff:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing errors for snowflake syntax
2 participants