Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres specific CTEDefinitionSegment #2524

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Postgres specific CTEDefinitionSegment #2524

merged 1 commit into from
Jan 31, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Jan 31, 2022

Brief summary of the change made

Adds NOT MATERIALIZED, SEARCH BREADTH/DEPTH FIRST, and CYCLE clauses to Postgres CTEDefinitionSegment.
Closes #2523

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #2524 (15f37f3) into main (d3c9855) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2524   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          162       162           
  Lines        11696     11700    +4     
=========================================
+ Hits         11696     11700    +4     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_postgres_keywords.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_postgres.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c9855...15f37f3. Read the comment docs.

@tunetheweb tunetheweb merged commit c744e20 into sqlfluff:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for NOT MATERIALIZED CTEs in Postgres
2 participants