Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSQL: Add indentation for SET statement #2531

Merged
merged 8 commits into from
Jan 31, 2022

Conversation

jpers36
Copy link
Contributor

@jpers36 jpers36 commented Jan 31, 2022

Brief summary of the change made

Adding Indent/Dedent tags for TSQL's SET statement.

Are there any other side effects of this change that we should be aware of?

No.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.

@jpers36
Copy link
Contributor Author

jpers36 commented Jan 31, 2022

@tunetheweb tangentially, I did submit #2533 to add support for SET statements that set multiple session configuration settings, which is valid TSQL.

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #2531 (7eef44e) into main (c56f7ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2531   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          162       162           
  Lines        11700     11700           
=========================================
  Hits         11700     11700           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_tsql.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56f7ac...7eef44e. Read the comment docs.

@tunetheweb tunetheweb merged commit a1e875f into sqlfluff:main Jan 31, 2022
@tunetheweb
Copy link
Member

@tunetheweb tangentially, I did submit #2533 to add support for SET statements that set multiple session configuration settings, which is valid TSQL.

Raised #2535 while this extra test case is in mine. Would be great to get your view on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants