Allow L059 to be configured to always prefer quoted identifiers #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend L059 to allow user-defined configuration to set if the identifiers must be always quoted or preferably unquoted, and when quotes are necessary or wanted, which one to use.
Add new configurations for L059
Manage user-defined configuration to allow to force quoted identifiers, and prefer some quotes over others. See sqlfluff#2527
tunetheweb
requested changes
Feb 1, 2022
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
|
@tunetheweb Thanks a lot for your participation |
Remove attempt to manage the type of quote to be used for quoted_identifiers.
Fix tests as default dialect is ansi and backticks are not parsed. Added bigquery dialect tests to ensure this is working also with backticks when dialect is supporting them.
niconoe-
commented
Feb 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #2537 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 11758 11768 +10
=========================================
+ Hits 11758 11768 +10
Continue to review full report at Codecov.
|
tunetheweb
requested changes
Feb 2, 2022
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
tunetheweb
approved these changes
Feb 2, 2022
tunetheweb
changed the title
|
Thanks for working on this @niconoe- ! And for being patient with all the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
fixes #2527 by providing a configuration option on the L059 rule.
Are there any other side effects of this change that we should be aware of?
No side effects expected as the default values for the newly added configuration are respecting the previous L059 behavior.
Pull Request checklist
.ymlrule test cases intest/fixtures/rules/std_rule_cases.Even though I think I have fulfilled the requirements in terms of development, tests, documentation, please do not hesitate to help me ensuring this PR is OK, as I didn't wrote anything in python since a decade (literally), and I'm not 100% sure I respected the code of conduct (and if I failed, I'm sorry, I'll fix my mistakes).