Correct parsing for BigQuery SELECT REPLACE clauses.
#2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sqlfluff#2549 BQ's `SELECT REPLACE` requires parentheses around replaced fields, but the BQ dialect implementation was permittig an invalid version without it. This implemetation had the side effect of also failing to parse a `SELECT REPLACE()` with trailing comma and no additional fields, e.g the following would not parse correctly. ```sql SELECT * REPLACE(foo AS bar), FROM foo ``` Removing the unparenthesised version from the dialect makes the parsing more consistent with what BQ actually accepts, requiring the parentheses, and resolves the parse error on the trailing comma.
tunetheweb
approved these changes
Feb 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #2550 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 11781 11781
=========================================
Hits 11781 11781
Continue to review full report at Codecov.
|
|
Thanks for that! |
|
Thanks for the quick merge and thanks for your work on sqlfluff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #2549
BQ's
SELECT REPLACErequires parentheses around replaced fields, but the BQ dialect implementation was permittig an invalid version without it.This implemetation had the side effect of also failing to parse a
SELECT REPLACE()with trailing comma and no additional fields, e.g the following would not parse correctly.Removing the unparenthesised version from the dialect makes the parsing more consistent with what BQ actually accepts, requiring the parentheses, and resolves the parse error on the trailing comma.
Are there any other side effects of this change that we should be aware of?
None that I'm aware of.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).Full autofix test cases intest/fixtures/linter/autofix.Other.Added appropriate documentation for the change.Created GitHub issues for any relevant followup/future enhancements if appropriate.