Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja and dbt templater: Fix "list index out of range" error #2555

Merged

Conversation

barrywhart
Copy link
Member

@barrywhart barrywhart commented Feb 3, 2022

Brief summary of the change made

Fixes #2541

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #2555 (3e82350) into main (52ab9dc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2555   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        11781     11777    -4     
=========================================
- Hits         11781     11777    -4     
Impacted Files Coverage Δ
src/sqlfluff/core/templaters/slicers/tracer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ab9dc...3e82350. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nit.

src/sqlfluff/core/templaters/slicers/tracer.py Outdated Show resolved Hide resolved
@tunetheweb tunetheweb changed the title jinja and dbt templater: Fix "list index out of range" error Jinja and dbt templater: Fix "list index out of range" error Feb 4, 2022
@tunetheweb tunetheweb merged commit 46c4a65 into sqlfluff:main Feb 4, 2022
@barrywhart
Copy link
Member Author

I think I need to revisit this in a follow-up PR. We should do something "bigger" about whitespace control. Will share more details in the next PR (hoping to work on that today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If statements in Jinja/dbt can trigger "list index out of range" error when used with whitespace controls
2 participants