Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exasol: Improve COMMENT and WITH [NO] DATA clause usage. #2583

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

sti0
Copy link
Contributor

@sti0 sti0 commented Feb 8, 2022

Brief summary of the change made

This solves #2501. The COMMENT clause could now be used within CREATE TABLE AS SELECT... or CREATE VIEW statements without the need to force the SELECT statement within parentheses. Addionally this solves another TODO which forced the SELECT statement to be within parentheses when using the WITH [NO] DATA clause in CREATE TABLE AS SELECT statements.

Are there any other side effects of this change that we should be aware of?

Nope

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@sti0 sti0 changed the title #2501 Improve COMMENT and WITH [NO] DATA clause usage. Exasol: Improve COMMENT and WITH [NO] DATA clause usage. Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #2583 (3ae198c) into main (e1d4ec9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2583   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        11852     11861    +9     
=========================================
+ Hits         11852     11861    +9     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_exasol.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d4ec9...3ae198c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants