L016: New option "ignore_comment_clause" to ignore column COMMENTs, etc. #2589
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2589 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 11876 11886 +10
=========================================
+ Hits 11876 11886 +10
Continue to review full report at Codecov.
|
| test_pass_ignore_comment_clause_snowflake: | ||
| pass_str: | | ||
| CREATE TABLE foo_table (bar INTEGER) COMMENT = 'very long comment line, exceeding max_line_lengthvery long comment line, exceeding max_line_length very long comment line, exceeding max_line_length very long comment line, exceeding max_line_length' | ||
| configs: | ||
| core: | ||
| dialect: snowflake | ||
| rules: | ||
| L016: | ||
| ignore_comment_clause: True |
There was a problem hiding this comment.
Should we add a test case for when the line is very long - even when ignoring the comment clause? It should still fail.
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
…/github.com/barrywhart/sqlfluff into bhart-issue_2554_l016_ignore_comment_clause
|
@tunetheweb: I added the test case you suggested. Ready for another review. |
|
The tests were failing so was waiting for them to pass before approving. |
|
Hmm, maybe I broke something. Will look again in a bit. |
…/github.com/barrywhart/sqlfluff into bhart-issue_2554_l016_ignore_comment_clause
|
@tunetheweb: I think it'll work now. We just needed to apply the same config setting rename to the test case |
Brief summary of the change made
Fixes #2554
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.